Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--xsd should be the default and --disable-xsd an option #567

Closed
bgruening opened this issue Sep 18, 2016 · 8 comments
Closed

--xsd should be the default and --disable-xsd an option #567

bgruening opened this issue Sep 18, 2016 · 8 comments

Comments

@bgruening
Copy link
Member

I think the new xsd option should be the default behavior. @jmchilton any reason not to do so?

@jmchilton
Copy link
Member

I think we would want to make lxml a required dependency then, which I was hesistant to do before because it required some libraries that weren't commonly installed on base systems but just the other day I did a pip install of it from pypi and got a binary manylinux wheel! It was very painless - so I'm up for this I think.

@nsoranzo
Copy link
Member

Or even always enabled?

@bgruening
Copy link
Member Author

;) I don't think there is any harm in offering a disable option for this, e..g if someone ships its own modifications to Galaxy. But the important part is to make it default :)
We can also leave out the disable option!

@peterjc
Copy link
Contributor

peterjc commented Sep 22, 2016

👍 on making XSD validation the default for linting tool XML files.

@peterjc
Copy link
Contributor

peterjc commented Sep 23, 2016

Enabling this has flagged all sorts of little things, proving very helpful - all of these were problems with input parameter help text using the wrong tag:

@peterjc
Copy link
Contributor

peterjc commented Sep 23, 2016

Another common error in my tools, using required=... rather than optional=..,

@peterjc
Copy link
Contributor

peterjc commented Sep 23, 2016

There are a number of failures on https://github.com/galaxyproject/tools-iuc with the XSD validation, I will start filing issues...

@jmchilton
Copy link
Member

@peterjc There is a WIP PR that I think covers all of them galaxyproject/tools-iuc#939. Might be better just to break it up and get some traction on individual parts though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants