Fix use of package_name attribute on CondaTarget objects
#1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Galaxy 23.1 `galaxy.tool_util.deps.mulled.util.build_target()` was changed to return a `CondaTarget` object instead of a (removed) `Target`. To avoid complications, this requires a bump to the galaxy-util and galaxy-tool-util packages to >=23.1 . Also, add type annotations to most related code. Fix galaxyproject/galaxy#17378 .
mvdbeek
approved these changes
Jan 30, 2024
|
Thank you! |
|
Thanks a lot @nsoranzo. Should we unpin the planemo monitor again? |
Yes, I think so. |
bernt-matthias
added a commit
to bernt-matthias/planemo-monitor
that referenced
this pull request
Jan 30, 2024
has been fixed galaxyproject/planemo#1424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Galaxy 23.1
galaxy.tool_util.deps.mulled.util.build_target()was changed to return aCondaTargetobject instead of a (removed)Target.To avoid complications, this requires a bump to the galaxy-util and galaxy-tool-util packages to >=23.1 .
Also, add type annotations to most related code.
Fix galaxyproject/galaxy#17378 .