Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CondaTarget misses package_name property #17378

Closed
bernt-matthias opened this issue Jan 29, 2024 · 2 comments · Fixed by galaxyproject/planemo#1424
Closed

CondaTarget misses package_name property #17378

bernt-matthias opened this issue Jan 29, 2024 · 2 comments · Fixed by galaxyproject/planemo#1424

Comments

@bernt-matthias
Copy link
Contributor

Describe the bug

https://github.com/galaxyproject/galaxy/pull/16181/files merged Target (which had package_name) into CondaTarget (which has package). planemo uses package_name and fails with AttributeError: 'CondaTarget' object has no attribute 'package_name' since the 23.1 is used.

xref galaxyproject/planemo-monitor#46

Galaxy Version and/or server at which you observed the bug
Galaxy Version: 23.1
@nsoranzo
Copy link
Member

I think it'd be fine to just update planemo to use the new syntax (I can do that), but let me know if you'd prefer to patch Galaxy instead.

@bernt-matthias
Copy link
Contributor Author

I have no preference. Guess nothing except Galaxy itself and planemo use this anyway.

nsoranzo added a commit to nsoranzo/planemo that referenced this issue Jan 30, 2024
@nsoranzo
Fix use of package_name attribute on CondaTarget objects
fb021ef 
In Galaxy 23.1 `galaxy.tool_util.deps.mulled.util.build_target()`
was changed to return a `CondaTarget` object instead of a (removed)
`Target`.

To avoid complications, this requires a bump to the galaxy-util and
galaxy-tool-util packages to >=23.1 .

Also, add type annotations to most related code.

Fix galaxyproject/galaxy#17378 .
nsoranzo added a commit to nsoranzo/planemo that referenced this issue Jan 30, 2024
@nsoranzo
Fix use of package_name attribute on CondaTarget objects
30c60d3 
In Galaxy 23.1 `galaxy.tool_util.deps.mulled.util.build_target()`
was changed to return a `CondaTarget` object instead of a (removed)
`Target`.

To avoid complications, this requires a bump to the galaxy-util and
galaxy-tool-util packages to >=23.1 .

Also, add type annotations to most related code.

Fix galaxyproject/galaxy#17378 .
@nsoranzo nsoranzo mentioned this issue Jan 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix use of package_name attribute on CondaTarget objects nsoranzo/planemo
2 participants
@nsoranzo @bernt-matthias