Not all exceptions will have a .read() method.

[peterjc]

Intended to partly address GitHub issue #116 (but the exception handling is still nasty). Before this change,

$ planemo shed_upload --shed_target testtoolshed --message "v0.0.8a again (testing uploads via planemo with API key)" --tar ~/toolshed_archives/venn_list_v0.0.8a.tar.gz ~/repositories/pico_galaxy/tools/venn_list
Traceback (most recent call last):
  File "/mnt/galaxy/repositories/planemo/.venv/bin/planemo", line 9, in <module>
    load_entry_point('planemo==0.9.0.dev0', 'console_scripts', 'planemo')()
  File "/mnt/galaxy/repositories/planemo/.venv/lib/python2.6/site-packages/click-4.0-py2.6.egg/click/core.py", line 664, in __call__
    return self.main(*args, **kwargs)
  File "/mnt/galaxy/repositories/planemo/.venv/lib/python2.6/site-packages/click-4.0-py2.6.egg/click/core.py", line 644, in main
    rv = self.invoke(ctx)
  File "/mnt/galaxy/repositories/planemo/.venv/lib/python2.6/site-packages/click-4.0-py2.6.egg/click/core.py", line 991, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/mnt/galaxy/repositories/planemo/.venv/lib/python2.6/site-packages/click-4.0-py2.6.egg/click/core.py", line 837, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/mnt/galaxy/repositories/planemo/.venv/lib/python2.6/site-packages/click-4.0-py2.6.egg/click/core.py", line 464, in invoke
    return callback(*args, **kwargs)
  File "/mnt/galaxy/repositories/planemo/.venv/lib/python2.6/site-packages/click-4.0-py2.6.egg/click/decorators.py", line 64, in new_func
    return ctx.invoke(f, obj, *args[1:], **kwargs)
  File "/mnt/galaxy/repositories/planemo/.venv/lib/python2.6/site-packages/click-4.0-py2.6.egg/click/core.py", line 464, in invoke
    return callback(*args, **kwargs)
  File "/mnt/galaxy/repositories/planemo/.venv/lib/python2.6/site-packages/planemo-0.9.0.dev0-py2.6.egg/planemo/commands/cmd_shed_upload.py", line 63, in cli
    exit_code = shed.for_each_repository(upload, path, **kwds)
  File "/mnt/galaxy/repositories/planemo/.venv/lib/python2.6/site-packages/planemo-0.9.0.dev0-py2.6.egg/planemo/shed.py", line 422, in for_each_repository
    function(realized_repository)
  File "/mnt/galaxy/repositories/planemo/.venv/lib/python2.6/site-packages/planemo-0.9.0.dev0-py2.6.egg/planemo/commands/cmd_shed_upload.py", line 61, in upload
    return __handle_upload(ctx, realized_repository, **kwds)
  File "/mnt/galaxy/repositories/planemo/.venv/lib/python2.6/site-packages/planemo-0.9.0.dev0-py2.6.egg/planemo/commands/cmd_shed_upload.py", line 99, in __handle_upload
    exception_content = e.read()
AttributeError: 'ConnectionError' object has no attribute 'read'

With this fix:

$ planemo shed_upload --shed_target testtoolshed --message "v0.0.8a again (testing uploads via planemo with API key)" --tar ~/toolshed_archives/venn_list_v0.0.8a.tar.gz ~/repositories/pico_galaxy/tools/venn_list
Could not update venn_list
Unexpected response from galaxy: 400: {"content_alert": "", "err_msg": "No changes to repository."}

Clearly still room for improvement - this looks like JSON so we ought to be able to pull out the error message as the older error handling code tries to do.

[peterjc]

@erasche This is only a short term solution until you can sort out #116 properly.

[jmchilton]

Thanks for the fix @peterjc - I'll tweak it a little because it is causing the make lint to fail - but it is a solid improvement.

[peterjc]

The second .read() was bothering me too. Thanks.

[hexylena]

I'll finish up with #116 sometime today.

tor. 30. apr. 2015 kl. 07.31 skrev John Chilton notifications@github.com:

Merged #155 #155.

—
Reply to this email directly or view it on GitHub
#155 (comment).

[hexylena]

It ALL bothers me. It's ghastly but I was hitting all manner of different, awful bioblend/TS exceptions and so I hacked together something functional. Then I started bumping up against the --max-complexity limit and it just went downhill from there... I'm sure I can develop something more elegant.

[peterjc]

Good luck - there seems to be a lot of very different exceptions to think about here :(

[jmchilton]

Crap - didn't see you were going to work on this and I tried to fix it for travis. What do we think about - https://github.com/galaxyproject/planemo/compare/master...jmchilton:exception_handling?expand=1.

[peterjc]

Assuming api_exception_to_message(...) would get used elsewhere, that seems like a sensible refactoring.

[hexylena]

No worries @jmchilton, lgtm. :) Let's pretend I implemented it that nicely.