New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort planemo shed_upload tar-ball by filename #164

Merged
merged 1 commit into from Apr 30, 2015

Conversation

Projects
None yet
2 participants
@peterjc
Copy link
Contributor

peterjc commented Apr 30, 2015

This would resolve issue #159 by the simple expedient of building a list of all the files in the staging directory, and using the sorted list to build the tar-ball.

Note this does not explicitly handle directories, thus any empty directory would be missing from the tar-ball. Since the Tool Shed uses hg internally this does not matter (same for git too).

e.g. silly test case showing the desired sorting:

$ planemo shed_upload --tar_only  ~/repositories/pico_galaxy/tools/venn_list && tar -tzf shed_upload.tar.gz
cp /tmp/tmpYAjHCW shed_upload.tar.gz
aaa
test-data/magic.pdf
test-data/rhodopsin_proteins.fasta
test-data/venn_list.tabular
test-dataAAA
tools/venn_list/README.rst
tools/venn_list/tool_dependencies.xml
tools/venn_list/venn_list.py
tools/venn_list/venn_list.xml
toolsAAA
zzz
Sort planemo shed_upload tar-ball by filename.
See GitHub issue #159.

Note this does not explicitly handle directories, thus any empty
directory would be missing from the tar-ball.
@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Apr 30, 2015

Awesome - thanks a bunch!

jmchilton added a commit that referenced this pull request Apr 30, 2015

Merge pull request #164 from peterjc/sort_tar_ball
Sort planemo shed_upload tar-ball by filename

@jmchilton jmchilton merged commit 3b45e59 into galaxyproject:master Apr 30, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment