Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Avoid ambigous destination value in test case... #186
Suggestion: If the
The include source of "../shared_files/extra_test_data/**" would only find "../shared_files/extra_test_data/extra_test_file.txt" which after strip_components 3 gives "extra_test_file.txt"
Question: did the ".shed.yml" destination of "test-data" mean call this file "test-data" [sic] or use "test-data/extra_test_file.txt" instead? Why?
What if the include source glob matches multiple files? Then might expect destination must be a folder - since alternative means trying to map multiple input files to one in the tar-ball/
Using destination "test-data/" seem unambiguous and preferable.
(I found this issue during re-factoring while working on #180)
Yes - I think that I make the assumption in the code that if the glob matches more then one file the destination must be a directory. The test case was my verification that this was working without needing the
If you return an exception - like unmatched globs - I think
Update: This line https://github.com/galaxyproject/planemo/blob/master/planemo/shed/__init__.py#L775 is what I was referring to about "returning" an exception.
I can definitely work on that part - the concept of "missing" needs to be generalized to other sorts of validation exceptions. But as long as we get them out of that chunk of code as exceptions shed lint should handle it.