shed_upload include with strip_components and '..' in paths #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to handle include source paths combining
..
andstrip_components
, the path manipulation must be done before calculating relative paths (which drops the..
entries). The easiest way to do this seemed to me to move all the path realisation out of theRealizedFile
object, thus the refactoring.(This is a corner case I missed while working on #185)
Motivating example peterjc/pico_galaxy@1029aa9 which wasn't working as expected.
i.e. With this
.shed.yml
include block:Before this fix:
With this fix:
Note: The test case may well be not quite as @jmchilton would write it - I was attempting to model it after the existing complex repository examples.