Bugfix: tool_init use from_work_dir only if file in command. #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug in the resulting tools using the output directly but having dummy from_work_dir files that are largely ignored by Galaxy under normal operation (but causing a somewhat more undefined behavior with Pulsar for instance). The updated example tools clarify this I think. See also galaxyproject#276 (ping @lecorguille).
|
More stylish ! Well done ! |
jmchilton
added a commit
that referenced
this pull request
Aug 3, 2015
Bugfix: tool_init use from_work_dir only if file in command.
|
Alright - thanks again for the contribution though. I had completely forgotten about this bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug in the resulting tools using the output directly but having dummy from_work_dir files that are largely ignored by Galaxy under normal operation (but causing a somewhat more undefined behavior with Pulsar for instance). The updated example tools clarify this I think.
See also #276 (ping @lecorguille).