New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: tool_init use from_work_dir only if file in command. #277

Merged
merged 1 commit into from Aug 3, 2015

Conversation

Projects
None yet
2 participants
@jmchilton
Copy link
Member

jmchilton commented Jul 31, 2015

Fixes bug in the resulting tools using the output directly but having dummy from_work_dir files that are largely ignored by Galaxy under normal operation (but causing a somewhat more undefined behavior with Pulsar for instance). The updated example tools clarify this I think.

See also #276 (ping @lecorguille).

Bugfix: tool_init use from_work_dir only if file in command.
Fixes bug in the resulting tools using the output directly but having dummy from_work_dir files that are largely ignored by Galaxy under normal operation (but causing a somewhat more undefined behavior with Pulsar for instance). The updated example tools clarify this I think.

See also #276 (ping @lecorguille).
@lecorguille

This comment has been minimized.

Copy link
Member

lecorguille commented Aug 3, 2015

More stylish ! Well done !
Thanks

jmchilton added a commit that referenced this pull request Aug 3, 2015

Merge pull request #277 from jmchilton/tool_init_work
Bugfix: tool_init use from_work_dir only if file in command.

@jmchilton jmchilton merged commit 5611bf8 into galaxyproject:master Aug 3, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jmchilton

This comment has been minimized.

Copy link
Member Author

jmchilton commented Aug 3, 2015

Alright - thanks again for the contribution though. I had completely forgotten about this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment