New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cast repo_id as string for shed compat #398

Merged
merged 1 commit into from Jan 2, 2016

Conversation

Projects
None yet
3 participants
@erasche
Copy link
Member

erasche commented Jan 1, 2016

Seriously the only thing :) Since repo_ids are now returned as ints rather thans strs, we cast them as a string and we're done.

@erasche erasche changed the title Only change needed for shed compatability cast repo_id as string for shed compat Jan 1, 2016

@jmchilton jmchilton referenced this pull request Jan 1, 2016

Open

Winter Break Sprint #1

19 of 51 tasks complete
@erasche

This comment has been minimized.

Copy link
Member Author

erasche commented Jan 1, 2016

Okay, pretty sure test failures aren't my fault...

@bgruening

This comment has been minimized.

Copy link
Member

bgruening commented Jan 1, 2016

Interesting something broke with the installation. I had the some problem today in galaxytools: ValueError: malformed string. I simple pip install planemo fixed it for me. Before I was installing from github directly.

@jmchilton jmchilton force-pushed the shed-compat branch from c22d24a to 790a1ee Jan 2, 2016

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Jan 2, 2016

Rebased this against the latest master which fixes though planemo install bugs. I have to stop tolerating @jmchilton turning these projects turning red.

jmchilton added a commit that referenced this pull request Jan 2, 2016

Merge pull request #398 from galaxyproject/shed-compat
cast repo_id as string for shed compat

@jmchilton jmchilton merged commit 6d9fc8d into master Jan 2, 2016

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jmchilton jmchilton deleted the shed-compat branch Jan 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment