New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check .shed.yml owner against credentials during shed creation. #425

Merged
merged 1 commit into from Mar 29, 2016

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

jmchilton commented Mar 29, 2016

Fixes #246.

Check .shed.yml owner against credentials during shed creation.
Fixes #246.

Rebased with advice from @nsoranzo - as always thanks eagle eyes.
@peterjc

This comment has been minimized.

Copy link
Contributor

peterjc commented Mar 29, 2016

Not tested, but looks good in principle.

@@ -61,6 +61,8 @@
"in .shed.yml and --name on the command-line.")
REALIZAION_PROBLEMS_MESSAGE = ("Problem encountered executing action for one or more "
"repositories.")
INCORRECT_OWNER_MESSAGE = ("Attempting to create a repository with configured "
"owner [%s] that does not matched API user [%s].")

This comment has been minimized.

@nsoranzo

nsoranzo Mar 29, 2016

Member

s/matched/match/

@@ -1191,6 +1193,12 @@ def find_repository_id(self, ctx, shed_context):
def create(self, ctx, shed_context):
"""Wrapper for creating the endpoint if it doesn't exist
"""
context_owner = shed_context.owner()
config_owner = self.config["owner"]

This comment has been minimized.

@nsoranzo

nsoranzo Mar 29, 2016

Member

Is self.config["owner"] always set? If not, self.config.get("owner", None) may be more appropriate.

@jmchilton jmchilton force-pushed the jmchilton:fix_246 branch from 77dad20 to 3314598 Mar 29, 2016

@jmchilton jmchilton merged commit 14e1e3b into galaxyproject:master Mar 29, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

jmchilton added a commit that referenced this pull request Apr 25, 2016

Revert #425 - it was broken.
See #437.

Release 0.24.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment