New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default (overrideable) external Galaxies to not use path pasting. #816

Merged
merged 1 commit into from May 14, 2018

Conversation

Projects
None yet
2 participants
@jmchilton
Copy link
Member

jmchilton commented May 13, 2018

No description provided.


def upload_func(upload_target):

def _attach_file(upload_payload, uri, index=0):
is_path = not uri.startswith("http://") and not uri.startswith("https://") and not not uri.startswith("ftp://")

This comment has been minimized.

@bgruening

bgruening May 13, 2018

Member

not not not

@jmchilton jmchilton force-pushed the jmchilton:external_uri branch 2 times, most recently from 4c783a2 to 28e22ef May 13, 2018

@bgruening

This comment has been minimized.

Copy link
Member

bgruening commented May 14, 2018

I got a 'BaseGalaxyConfig' object has no attribute 'allow_path_paste' with this branch.

@jmchilton jmchilton force-pushed the jmchilton:external_uri branch from 28e22ef to 7264f12 May 14, 2018

@jmchilton

This comment has been minimized.

Copy link
Member Author

jmchilton commented May 14, 2018

I've rebased with something I hope fixes that, thanks @bgruening - my searching around Travis had failed to find the error.

@jmchilton jmchilton merged commit 9fc6baf into galaxyproject:master May 14, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment