Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase IO polling interval over time #891

Merged

Conversation

martenson
Copy link
Member

@martenson martenson commented Nov 8, 2018

Introduces configurable option --polling_backoff <integer> which, atm, increases polling interval by <integer> second(s) every round. This considerably lowers the load on the target instance when waiting on dataset state changes.

xref: galaxyproject/usegalaxy-playbook#164

docs/test_format.rst Outdated Show resolved Hide resolved
Co-Authored-By: martenson <marten@bx.psu.edu>
docs/test_format.rst Outdated Show resolved Hide resolved
planemo/io.py Outdated Show resolved Hide resolved
planemo/io.py Outdated Show resolved Hide resolved
planemo/io.py Outdated Show resolved Hide resolved
planemo/io.py Outdated Show resolved Hide resolved
planemo/galaxy/activity.py Outdated Show resolved Hide resolved
nsoranzo and others added 2 commits November 8, 2018 20:43
Co-Authored-By: martenson <marten@bx.psu.edu>
from a flag to an argument-receiving option
docs/test_format.rst Outdated Show resolved Hide resolved
@nsoranzo
Copy link
Member

nsoranzo commented Nov 9, 2018

Thanks @martenson for changing it to an int, I wanted to suggest it, but than backed off 😆

nsoranzo and others added 2 commits November 8, 2018 21:21
Co-Authored-By: martenson <marten@bx.psu.edu>
Copy link
Member

@hexylena hexylena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I retract my gitter comments, looks fine even with 5-10s of backoff at each step.

Copy link
Member

@jmchilton jmchilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, also prefer it as an int - much more general IMO.

@jmchilton jmchilton merged commit 7569eb3 into galaxyproject:master Nov 9, 2018
@martenson martenson deleted the increase-polling-interval-overtime branch November 9, 2018 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants