New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase IO polling interval over time #891

Merged
merged 10 commits into from Nov 9, 2018

Conversation

Projects
None yet
5 participants
@martenson
Copy link
Member

martenson commented Nov 8, 2018

Introduces configurable option --polling_backoff <integer> which, atm, increases polling interval by <integer> second(s) every round. This considerably lowers the load on the target instance when waiting on dataset state changes.

xref: galaxyproject/usegalaxy-playbook#164

martenson added some commits Nov 7, 2018

@martenson martenson requested review from jmchilton and erasche Nov 8, 2018

Show resolved Hide resolved docs/test_format.rst Outdated
fix typo
Co-Authored-By: martenson <marten@bx.psu.edu>
Show resolved Hide resolved docs/test_format.rst Outdated
Show resolved Hide resolved planemo/io.py Outdated
Show resolved Hide resolved planemo/io.py Outdated
Show resolved Hide resolved planemo/io.py Outdated
Show resolved Hide resolved planemo/io.py Outdated

martenson added some commits Nov 9, 2018

Merge branch 'increase-polling-interval-overtime' of github.com:marte…
…nson/planemo into increase-polling-interval-overtime
Show resolved Hide resolved planemo/galaxy/activity.py Outdated

nsoranzo and others added some commits Nov 9, 2018

lint fix
Co-Authored-By: martenson <marten@bx.psu.edu>
refactor polling config
from a flag to an argument-receiving option
Show resolved Hide resolved docs/test_format.rst Outdated
@nsoranzo

This comment has been minimized.

Copy link
Member

nsoranzo commented Nov 9, 2018

Thanks @martenson for changing it to an int, I wanted to suggest it, but than backed off 😆

nsoranzo and others added some commits Nov 9, 2018

fix typo
Co-Authored-By: martenson <marten@bx.psu.edu>
@erasche

erasche approved these changes Nov 9, 2018

Copy link
Member

erasche left a comment

Looks good to me. I retract my gitter comments, looks fine even with 5-10s of backoff at each step.

@jmchilton
Copy link
Member

jmchilton left a comment

Perfect, also prefer it as an int - much more general IMO.

@jmchilton jmchilton merged commit 7569eb3 into galaxyproject:master Nov 9, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@martenson martenson deleted the martenson:increase-polling-interval-overtime branch Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment