Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unicodify() on exceptions and subprocess outputs #944

Merged
merged 3 commits into from
Jul 17, 2019
Merged

Use unicodify() on exceptions and subprocess outputs #944

merged 3 commits into from
Jul 17, 2019

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Jul 16, 2019 •
edited
Loading

Fix traceback reported in #939 (comment) .

Also fix 2 old broken tests.

@nsoranzo nsoranzo requested a review from mvdbeek July 17, 2019 11:44
mvdbeek
mvdbeek approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @nsoranzo!

@mvdbeek mvdbeek merged commit 1df1982 into galaxyproject:master Jul 17, 2019
@nsoranzo nsoranzo deleted the unicodify_exceptions branch July 17, 2019 12:08
@nsoranzo
Copy link
Member Author

@mvdbeek Thanks for the merge!

I think we should apply the same changes (in particular adding sort_keys=True to json.dump) to all data managers in your galaxyproject/tools-iuc#2032 , which should simplify the DM testing.

@mvdbeek
Copy link
Member

mvdbeek commented Jul 17, 2019

Yeah, I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek mvdbeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsoranzo @mvdbeek