New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planemo tool_init should wrap $input_file in double quotes #98

Merged
merged 1 commit into from Mar 9, 2015

Conversation

Projects
None yet
2 participants
@peterjc
Copy link
Contributor

peterjc commented Mar 8, 2015

I was reading the writing a tool docs for v0.6.0 https://planemo.readthedocs.org/en/latest/writing.html and noticed the command string template did not double quote the filenames:

    <command><![CDATA[
        seqtk seq -a $input1 > $output1
    ]]></command>

This untested change attempts to do that, and ought to give:

    <command><![CDATA[
        seqtk seq -a "$input1" > "$output1"
    ]]></command>
planemo tool_init should wrap $input_file in double quotes
I was reading the writing a tool docs for v0.6.0 https://planemo.readthedocs.org/en/latest/writing.html and noticed the command string template did not double quote the filenames:

```
    <command><![CDATA[
        seqtk seq -a $input1 > $output1
    ]]></command>
```

This *untested* change attempts to do that.
@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Mar 9, 2015

Awesome, thanks for the fix.

jmchilton added a commit that referenced this pull request Mar 9, 2015

Merge pull request #98 from peterjc/patch-1
planemo tool_init should wrap $input_file in double quotes

@jmchilton jmchilton merged commit c811282 into galaxyproject:master Mar 9, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment