Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parameters submission #207

Merged
merged 1 commit into from Sep 5, 2019

Conversation

gmauro
Copy link
Member

@gmauro gmauro commented Sep 5, 2019

Preamble: CondorQueueManager handles parameters from the Pulsar config file (app.yml) but ignores parameters submitted from Galaxy.

This PR allows Pulsar to properly handle the HTCondor parameters received from Galaxy:
submit_params variable contains parameters from the JSON received from Galaxy
self.submission_params variable contains parameters from the app.yml file.

In the event of a conflict, the setting on the Pulsar side prevails.

@coveralls
Copy link

Coverage Status

Coverage increased (+10.6%) to 80.85% when pulling d1980e3 on gmauro:submission_params into 0e3556d on galaxyproject:master.

@jmchilton jmchilton merged commit b82ef4f into galaxyproject:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants