Implement job and tool stdio separation #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
added a commit
to mvdbeek/galaxy
that referenced
this pull request
Apr 6, 2023
4 tasks
mvdbeek
added a commit
to mvdbeek/galaxy
that referenced
this pull request
Apr 6, 2023
mvdbeek
added a commit
to mvdbeek/galaxy
that referenced
this pull request
Apr 6, 2023
mvdbeek
added a commit
to mvdbeek/galaxy
that referenced
this pull request
Apr 6, 2023
mvdbeek
added a commit
to mvdbeek/galaxy
that referenced
this pull request
Apr 6, 2023
|
hmm, 20 new test errors for the framework tests against the master branch (22.05). I guess that was to be expected, but it's no good that dev seem to time out on the parallelism tests |
4 tasks
mvdbeek
force-pushed
the
fix_stdout_stderr
branch
from
7493cbe
to
fc5b791
Compare
|
Feel free to just increase that complexity threshold if it is a complex thing to "fix". |
mvdbeek
force-pushed
the
fix_stdout_stderr
branch
6 times, most recently
from
3993072
to
19daf80
Compare
Closed
|
Alright, the directory metadata variant framework tests pass completely! And the extended metadata tests seem to just have an issue with the stdio redirection. |
mvdbeek
force-pushed
the
fix_stdout_stderr
branch
from
19daf80
to
ab5a528
Compare
and always set up job i/o redirection on the pulsar side. Since pulsar stdio is broken prior to this on 23.0 this is maybe a good time to make the switch. Seems like this detail should be controlled on pulsar, not Galaxy.
This will write to metadata/memory_statement.log, instead of the working directory. Fixes a bunch of tests that use metadata collection.
mvdbeek
force-pushed
the
fix_stdout_stderr
branch
from
ab5a528
to
a0ee452
Compare
4 tasks
mvdbeek
force-pushed
the
fix_stdout_stderr
branch
from
7ce2875
to
ec37128
Compare
mvdbeek
force-pushed
the
fix_stdout_stderr
branch
from
ec37128
to
1bab112
Compare
|
I've deployed this as https://pypi.org/project/pulsar-galaxy-lib/0.15.0.dev2/ for testing on the Galaxy side (galaxyproject/galaxy#15915) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and always set up job i/o redirection on the pulsar side. Since pulsar stdio is broken prior to this on 23.0 this is maybe a good time to make the switch. Seems like this detail should be controlled on pulsar, not Galaxy.