Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for installing R 3.1.2 on osx #509

Closed
wants to merge 1 commit into from

Conversation

gregvonkuster
Copy link
Contributor

I have also tested these changes on Linux and all installs fine.

<environment_variable name="C_INCLUDE_PATH" action="prepend_to">$INSTALL_DIR/include</environment_variable>
<environment_variable name="CPLUS_INCLUDE_PATH" action="prepend_to">$INSTALL_DIR/include</environment_variable>
<environment_variable name="C_INCLUDE_PATH" action="prepend_to">$INSTALL_DIR/include/ncursesw</environment_variable>
<environment_variable name="CPLUS_INCLUDE_PATH" action="prepend_to">$INSTALL_DIR/include/ncursesw</environment_variable>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really ncurses__w__? I don't have this under Linux? Is this something specific to OS-X?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is what I found. Here is is on my Mac:

$ pwd
/Users/gvk/work/ts_install/tool_dependency_dir/ncurses/5.9/iuc/package_ncurses_5_9/77ecbc5b0449/include/ncursesw
MacBook-Pro-2:ncursesw gvk$ ll
total 368
drwxr-xr-x 11 gvk staff 374 Dec 29 20:25 .
drwxr-xr-x 3 gvk staff 102 Dec 29 20:25 ..
-rw-r--r-- 1 gvk staff 2891 Dec 29 20:25 eti.h
-rw-r--r-- 1 gvk staff 18005 Dec 29 20:25 form.h
-rw-r--r-- 1 gvk staff 11969 Dec 29 20:25 menu.h
-rw-r--r-- 1 gvk staff 93597 Dec 29 20:25 ncurses.h
-rw-r--r-- 1 gvk staff 3925 Dec 29 20:25 ncurses_dll.h
-rw-r--r-- 1 gvk staff 4072 Dec 29 20:25 panel.h
-rw-r--r-- 1 gvk staff 40299 Dec 29 20:25 term.h
-rw-r--r-- 1 gvk staff 3479 Dec 29 20:25 termcap.h
-rw-r--r-- 1 gvk staff 3109 Dec 29 20:25 unctrl.h

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different revision, but it looks like this for me:

[galaxy@cn029 ~]$ ls -l /usr/local/tools/ncurses/5.9/iuc/package_ncurses_5_9/5e1760c773ba/include/
insgesamt 4
drwxr-xr-x+ 2 galaxy galaxy 4096  2. Aug 21:13 ncurses

This is unfortunate ....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be different packages: openwrt/packages#526 one is with UTF-8 support. Let's figure our how we can compile the other one on your OS-X. There is hopefully a build switch :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but I'm kinda confused how I got a different package using the same install recipe which downloads the same source. Hmmm...also I just realized I may not have actually tested these changes on Linux. I thought I had, but looking again, I think I was using the original recipes on Linux (got confused cause my Linux env is remote). So, not quite sure how to proceed here...maybe I'll get some sleep first. ;)

@mvdbeek
Copy link
Member

mvdbeek commented Jan 3, 2016

@gregvonkuster for me it is sufficient to remove all those export statements before ./configure ... perhaps that's a better fix?
This is on the latest dev branch of galaxy, el capitan 10.11.2, gcc installed from the CommandLineTools package, with a clean galaxy instance and the following brew environment:

cloog
gcc
gdbm
gettext
git
glib
gmp
gnupg
igv
isl
libffi
libmpc
mpfr
node
openssl
p7zip
pkg-config
postgresql
python
sqlite
unp
wakeonlan
wget

@gregvonkuster
Copy link
Contributor Author

@mvdbeek Yes, that's what I discovered as well (you/re referring to the R recipe, right?). I'm running the dev branch of galaxy, el capitan 10.11.2 as well, and I only have the the following installed via brew:pkg-config, gcc. Not sure what version of OS X all the export statements actually worked on, but they do not work on El Capitan.

@mvdbeek
Copy link
Member

mvdbeek commented Jan 3, 2016

Yes! I think the issue with the export statements is that on OS X this somehow fails if any of them is not defined.

@gregvonkuster
Copy link
Contributor Author

Closing since this works for OS X https://toolshed.g2.bx.psu.edu/view/mvdbeek/package_r_3_1_2/174b90e5a7ec

@gregvonkuster gregvonkuster deleted the misc_fixes branch January 3, 2016 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants