Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and fix dryrun #82

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Refactor and fix dryrun #82

merged 2 commits into from
Mar 3, 2023

Conversation

nuwang
Copy link
Member

@nuwang nuwang commented Feb 18, 2023

This PR:

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 4211399093

  • 36 of 38 (94.74%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 96.915%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tpv/commands/dryrunner.py 28 30 93.33%
Totals Coverage Status
Change from base Build 4180007688: 0.03%
Covered Lines: 941
Relevant Lines: 964
💛 - Coveralls

bgruening
bgruening reviewed Feb 18, 2023
View reviewed changes
setup.py
@@ -15,6 +15,8 @@
with open("README.md", "r") as fh:
long_description = fh.read()

# Galaxy's runtime environment and packages are implicitly assumed to be present, and only
# explicitly installed for tests.
REQS_FULL = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ruamel.yaml and requests seems to be a core dependency
watchdog is a conditional dependency, which we could install if TPV is used.

https://github.com/galaxyproject/galaxy/blob/dev/lib/galaxy/dependencies/pinned-requirements.txt#L160

@bgruening
Copy link
Member

Thanks @nuwang for working on this!

@nuwang nuwang requested a review from cat-bro February 24, 2023 07:26
cat-bro
cat-bro approved these changes Mar 3, 2023
View reviewed changes
Copy link
Collaborator

@cat-bro cat-bro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nuwang
Copy link
Member Author

nuwang commented Mar 3, 2023

Thanks for reviewing.

@nuwang nuwang merged commit 0f31e40 into main Mar 3, 2023
@nuwang nuwang deleted the refactor_fix_dryrun branch March 3, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgruening bgruening bgruening left review comments

@cat-bro cat-bro cat-bro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TPV dry-run failing with error
4 participants
@nuwang @coveralls @bgruening @cat-bro