Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obitools first version #3152

Merged
merged 88 commits into from
Feb 28, 2022
Merged

Obitools first version #3152

merged 88 commits into from
Feb 28, 2022

Conversation

yvanlebras
Copy link
Collaborator

Hi GTN!

A first draft version of Obitools eDNA / metabarcoding tutorial, from this history: https://ecology.usegalaxy.eu/u/ylebras/h/tuto-obitools

@yvanlebras yvanlebras requested a review from a team as a code owner February 3, 2022 22:57
@hexylena
Copy link
Member

It's fine if they don't have a github username, if they don't just put github: false when you add them to the CONTRIBUTORS.yaml (and make up a 'username' for them.)

@hexylena
Copy link
Member

c'est vert!! Wonderful!

@yvanlebras
Copy link
Collaborator Author

Hey hey! It appears to me I adressed all comments, thank you so much Anne, Cristobal !!!!

@yvanlebras
Copy link
Collaborator Author

it appears I have an issue with an URL:

(https://pythonhosted.org/OBITools/welcome.html) is an invalid URL

Any idea @hexylena ? Do you think we an merge afterthat?


Citation: Boyer F., Mercier C., Bonin A., Taberlet P., Coissac E. (2016) OBITools: [a Unix-inspired software package for DNA metabarcoding](https://pubmed.ncbi.nlm.nih.gov/25959493/). Molecular Ecology Resources.

The OBITools commands consider a sequence record as an entity composed of five distinct elements. Two of them are mandatory, the identifier (id) and the DNA or protein sequence itself. The id is a single word composed of characters, digits, and other symbols like dots or underscores excluding spaces. Formally, the ids should be unique within a dataset and should identify each sequence record unambiguously, but only a few OBITools actually rely on this property. The three other elements composing a sequence record are optional. They consist in a sequence definition, a quality vector, and a set of attributes. The last element is a set of attributes qualifying the sequence, each attribute being described by a key=value pair. The set of attributes is the central concept of the OBITools system. When an OBITools command is run on the sequence records included in a dataset, the result of the computation often consist in the addition of new attributes completing the annotation of each sequence record. This strategy of sequence annotation allows the OBITools to return their results as a new sequence record file that can be used as the input of another OBITools program, ultimately creating complex pipelines (source: [(https://pythonhosted.org/OBITools/welcome.html)]((https://pythonhosted.org/OBITools/welcome.html))).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The OBITools commands consider a sequence record as an entity composed of five distinct elements. Two of them are mandatory, the identifier (id) and the DNA or protein sequence itself. The id is a single word composed of characters, digits, and other symbols like dots or underscores excluding spaces. Formally, the ids should be unique within a dataset and should identify each sequence record unambiguously, but only a few OBITools actually rely on this property. The three other elements composing a sequence record are optional. They consist in a sequence definition, a quality vector, and a set of attributes. The last element is a set of attributes qualifying the sequence, each attribute being described by a key=value pair. The set of attributes is the central concept of the OBITools system. When an OBITools command is run on the sequence records included in a dataset, the result of the computation often consist in the addition of new attributes completing the annotation of each sequence record. This strategy of sequence annotation allows the OBITools to return their results as a new sequence record file that can be used as the input of another OBITools program, ultimately creating complex pipelines (source: [(https://pythonhosted.org/OBITools/welcome.html)]((https://pythonhosted.org/OBITools/welcome.html))).
The OBITools commands consider a sequence record as an entity composed of five distinct elements. Two of them are mandatory, the identifier (id) and the DNA or protein sequence itself. The id is a single word composed of characters, digits, and other symbols like dots or underscores excluding spaces. Formally, the ids should be unique within a dataset and should identify each sequence record unambiguously, but only a few OBITools actually rely on this property. The three other elements composing a sequence record are optional. They consist in a sequence definition, a quality vector, and a set of attributes. The last element is a set of attributes qualifying the sequence, each attribute being described by a key=value pair. The set of attributes is the central concept of the OBITools system. When an OBITools command is run on the sequence records included in a dataset, the result of the computation often consist in the addition of new attributes completing the annotation of each sequence record. This strategy of sequence annotation allows the OBITools to return their results as a new sequence record file that can be used as the input of another OBITools program, ultimately creating complex pipelines (source: [OBITools Welcome](https://pythonhosted.org/OBITools/welcome.html)).

I think the double () was the issue, and yes, we can merge after this!! Amazing work @yvanlebras

hexylena
hexylena previously approved these changes Feb 28, 2022
@hexylena hexylena merged commit a3a679c into galaxyproject:main Feb 28, 2022
@hexylena
Copy link
Member

Congrats @yvanlebras et al!

@bgruening
Copy link
Member

🎉

@yvanlebras
Copy link
Collaborator Author

AMAZING!!! THANK YOU SOME MUCH ;) Helena ! Saskia ! Galaxy-E team !!! All !!!!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants