allow to work with Rails 4 production #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related issue #333 |
|
Also #307 |
galetahub
added a commit
that referenced
this pull request
Oct 24, 2013
allow to work with Rails 4 production
|
MANY THANKS! |
|
@Mik-die 👍 👍 👍 |
| // Add the timestamp, except for directories. | ||
| if ( resource.charAt( resource.length - 1 ) != '/' ){ | ||
| var url = resource.match( /^(.*?:\/\/[^\/]*)\/assets\/(.+)/ ); | ||
| if(url) resource = url[1] + (CKEDITOR_ASSETS_MAPPING[url[2]] || '/assets/' + url[2]); |
There was a problem hiding this comment.
This part doesn't work if the values in CKEDITOR_ASSETS_MAPPING are absolute URLs (including host part), which will be the case if Rails' config.asset_host is set.
|
Unfortunately this won't work with future versions of sprockets-rails, see rails/sprockets-rails#96 |
|
This option will be configurable rails/sprockets-rails#100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds additional javascript and doesn't change functionality of existing gem.
If some user want to use ckeditor in rails 4 production, all he needs is to require this javascript and add tiny rake task in own rails application code, as described in
readme.I already use this patch in my production, if I detect any errors in future, I'll fix these.