New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reminders select query statement; closes #1614 #375
Conversation
0009c92
to
0c856ed
Compare
With this PR, everything seems to be working properly on my side ✌️ |
0c856ed
to
b86752b
Compare
Well... The tests are failing rightly 😞 With such a select query, this can only works when reminders are already existing in the database. Or in other words, this cannot work on a clean database or for the first reminders... Another interesting point : MySQL and PostgreSQL are throwing error that MariaDB doesn't : |
Oh :( PostgreSQL always have failed as expected. For MySQL and MariaDB, with default configuration, only a Warning is emitted; therefore an extra check is done in tests:
Looks like this has changed somehow in MariaDB; I'll probably have to add a test on that |
OK, well; but appart of that, would you be able to add a test case that is currently fixed by your proposal? Since #373 did not fix your issue; I guess my new test was wrong and I still have no idea how to reproduce... |
Please have a look at #376 😉 |
aed61ba
to
c3165cf
Compare
I keep this one open so I can take a look on it while trying to fix remaning cases |
c3165cf
to
f23f079
Compare
Since I've completely remove the "max" reminder type part of the query, this one is no longer needed. The only remaining change is the |
No description provided.