Fix reminders unit tests; refs #1614

[gagnieray]

No description provided.

[trasher]

Thank you very much, I'll take a look

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (402e9e7) 44.44% compared to head (887f030) 44.44%.

❗ Current head 887f030 differs from pull request most recent head f290ff2. Consider uploading reports for the commit f290ff2 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@                  Coverage Diff                   @@
##             feature/fix/1614     #376      +/-   ##
======================================================
- Coverage               44.44%   44.44%   -0.01%     
  Complexity               5880     5880              
======================================================
  Files                     142      142              
  Lines                   23886    23885       -1     
======================================================
- Hits                    10616    10615       -1     
  Misses                  13270    13270              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[trasher]

My latest commit fixes tests; could you confirm it seems working as expected on your side @gagnieray?

[gagnieray]

My latest commit fixes tests; could you confirm it seems working as expected on your side @gagnieray?

Unfortunately, no 😕

I wrote more tests. But they do not fail as expected (or at least not in the same conditions as things are failing on my instance). So I wonder if I wrote them correctly 🤔

Please, have a look at my latest commit.
And compare the results of the latest tests on github with my own below :

1. On case n°1 :

   galette/tests/Galette/Repository/tests/units/Reminders.php

   Lines 663 to 665 in 9ea3ecd

   	// #1 : test reminders
   	//
   	// Both members should be up-to-date and receive ALL the reminders.

   • first impending reminders are properly sent
   • second impending reminders fail
   • first late reminders fail
   • second late reminders are properly sent

2. On case n°2 :

   galette/tests/Galette/Repository/tests/units/Reminders.php

   Lines 904 to 910 in 9ea3ecd

   	// #2 : test reminders
   	//
   	// Only Member 1 renewed membership last year after last late reminder.
   	// Only Member 1 should now be up-to-date and receive ALL the reminders.
   	//
   	// For Member 2, if its user account has not been set to inactive, he/she
   	// should be outdated and receive only one late reminder this year.

   • first impending reminders are properly sent
   • second impending reminders fail
   • first late reminders fail : only one out of two reminders is sent for the member late for more than 1 year
   • second late reminders are properly sent

3. On case n°3 :

   galette/tests/Galette/Repository/tests/units/Reminders.php

   Lines 1136 to 1140 in 9ea3ecd

   	// #3 : test reminders
   	//
   	// Member 2 has already received ALL reminders this year and
   	// is now outdated and should not receive other reminders until
   	// next membership period.

   • first impending reminder is properly sent
   • second impending reminder fails
   • first late reminder fails
   • second late reminder is properly sent

[trasher]

My latest commit fixes tests; could you confirm it seems working as expected on your side @gagnieray?

Unfortunately, no 😕

I wrote more tests. But they do not fail as expected (or at least not in the same conditions as things are failing on my instance). So I wonder if I wrote them correctly 🤔
[...]

After a quick review, I did no see anything wrong in your tests; but I probably need to spend much more time on that.

I've released 1.0.0 final, reminder issue is very old; I'll release a bugfixes version once it will be fixed.

I'll take a closer look later, thanks for the tests updates; maybe will I finally understand what's wrong :/

[gagnieray]

maybe will I finally understand what's wrong :/

I hope so ! 😄

I found new "clues". Please have a look at https://bugs.galette.eu/issues/1614#note-13

[trasher]

I've tried to understand why your latest commit make tests fails; but the only conclusion I got is tests expectations are currently wrong :D
But I also must admit I'm a bit lost in this test case... I'll probably revert your latest change to and work on a brand new test case reproducing what you describe on the tracker ticket.

Xmas approaching, I'm not sure I can take an eye before next year :)

[trasher]

1st and 2nd commits have been merged in #373; third commit has been ignored as I said, and last one is already in develop branch :)