Improve the solution for #1545 by sorting the settings menu properly

to be naturally ordered and case insensitive.
gallery · Dec 30, 2010 · a8b0254 · a8b0254
1 parent dd6da5e
commit a8b0254
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/modules/gallery/helpers/gallery_event.php b/modules/gallery/helpers/gallery_event.php
@@ -377,7 +377,7 @@ static function site_menu($menu, $theme, $item_css_selector) {
         module::event("admin_menu", $admin_menu, $theme);
 
         $settings_menu = $admin_menu->get("settings_menu");
-        sort($settings_menu->elements);
+        uasort($settings_menu->elements, array("Menu", "title_comparator"));
       }
     }
   }

diff --git a/modules/gallery/libraries/Admin_View.php b/modules/gallery/libraries/Admin_View.php
@@ -46,7 +46,7 @@ public function admin_menu() {
     module::event("admin_menu", $menu, $this);
 
     $settings_menu = $menu->get("settings_menu");
-    sort($settings_menu->elements);
+    uasort($settings_menu->elements, array("Menu", "title_comparator"));
 
     return $menu->render();
   }

diff --git a/modules/gallery/libraries/Menu.php b/modules/gallery/libraries/Menu.php
@@ -250,4 +250,8 @@ public function render() {
     $view->menu = $this;
     return $view;
   }
+
+  static function title_comparator($a, $b) {
+    return strnatcasecmp((string)$a->label, (string)$b->label);
+  }
 }