Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of other HD2017 models #51

Merged
merged 4 commits into from
Apr 14, 2020
Merged

Implementation of other HD2017 models #51

merged 4 commits into from
Apr 14, 2020

Conversation

zonca
Copy link
Member

@zonca zonca commented Apr 7, 2020

Implement d5 and d8

@zonca zonca self-assigned this Apr 7, 2020
zonca
zonca commented Apr 7, 2020
View reviewed changes
pysm/models/hd2017.py Outdated Show resolved Hide resolved
@zonca zonca requested a review from b-thorne April 7, 2020 19:38
@zonca
Copy link
Member Author

zonca commented Apr 14, 2020

I'll merge, @bthorne93 if you have any comment please send it over, I'll address them later on

@zonca zonca merged commit 61bdf61 into galsci:master Apr 14, 2020
@zonca zonca deleted the d5_d8 branch April 14, 2020 20:40
@zonca zonca mentioned this pull request Dec 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonshensley brandonshensley brandonshensley left review comments

@b-thorne b-thorne Awaiting requested review from b-thorne

Assignees

@zonca zonca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zonca @brandonshensley