Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import the hensley_draine_2017 model #20

Closed
zonca opened this issue Apr 25, 2019 · 10 comments
Closed

Import the hensley_draine_2017 model #20

zonca opened this issue Apr 25, 2019 · 10 comments
Assignees

Comments

@zonca
Copy link
Member

zonca commented Apr 25, 2019

Longer term, it would be nice to import the hensley_draine_2017 dust model, which is possibly the most complex model available in PySM. This could even require changing the architecture of PySM 3.

@zonca
Copy link
Member Author

zonca commented Sep 13, 2019

@bthorne93 are you still interested in working on this? Do you have an estimate of when you would have time to work on this?

@b-thorne
Copy link
Collaborator

@zonca Yes, sure. I actually have most of this implemented from when we spoke about it last. I can block off some time to work on this Friday next week, and should be doable in half a day. Would that be alright?

@zonca
Copy link
Member Author

zonca commented Sep 14, 2019

that is great, not much hurry, within 3 weeks would work great

@zonca
Copy link
Member Author

zonca commented Sep 26, 2019

@bthorne93 do you think you'll be able to work on this next week? I am trying to get all the PySM 2 models into PySM 3

@zonca
Copy link
Member Author

zonca commented Dec 11, 2019

@bthorne93 as of 5b124e8 I have implemented all PySM 2 models into PySM 3 except the 3 HD models.
Can you please complete the port before the break? if not, can you please point me to your work in progress so I can start from there?

@b-thorne
Copy link
Collaborator

@zonca this now exists on the branch hd17. I have the model implemented in a way that is equivalent to PySM v2. However, before making a pull request: it seems that sky.get_emission does not behave in the way I expect.

@b-thorne
Copy link
Collaborator

hd17 now cooperates with the new API to assume one channel being evaluated. Will need to be refactored, as currently it holds all the individual frequencies in memory, then integrates over the bandpass.

@zonca
Copy link
Member Author

zonca commented Dec 20, 2019

Thanks! This helps me a lot!
I'll pickup from here

@b-thorne
Copy link
Collaborator

I just pushed what I had left on my local version, which I think is closer to the correct way of doing it. I'll leave it to you from here, then!

@zonca
Copy link
Member Author

zonca commented Dec 14, 2020

implemented in #37 and #51

@zonca zonca closed this as completed Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants