fix: Refactor usage of __unstableGetClientIdsTree

[mxkae]

fixes #2798

[github-actions]

🤖 Pull request artifacts

file	commit
pr3104-stackable-3104-merge.zip	a33dcab

[github-actions]

Try this Pull Request in the WordPress playground: https://playground.wordpress.net/?mode=seamless#{"landingPage":"/wp-admin/post-new.php?post_type=page","preferredVersions":{"php":"latest","wp":"latest"},"steps":[{"step":"login","username":"admin","password":"password"},{"step":"installPlugin","pluginZipFile":{"resource":"url","url":"https://raw.githubusercontent.com/gambitph/Stackable/artifacts/pr3104-stackable-3104-merge.zip"}}]}

[bfintal]

Can we see if using getClientIdsWithDescendants will help with this?

Suggested change

	const [ blockCount, setBlockCount ] = useState( null )
	// Subscribe to all editor changes, so we can listen in to block structure changes.
	subscribe( () => {
	const count = select( 'core/block-editor' ).getGlobalBlockCount()
	if ( count !== blockCount ) {
	setBlockCount( count )
	}
	} )
	useEffect( () => {
	if ( blockCount ) {
	dispatch( 'stackable/block-editor' ).updateClientTree()
	}
	}, [ blockCount ] )
	const allClientIds = useSelect( select => {
	return select( 'core/block-editor' ).getClientIdsWithDescendants()
	} )
	useEffect( () => {
	console.log('did update' )
	dispatch( 'stackable/block-editor' ).updateClientTree()
	}, [ allClientIds ] )

[bfintal]

Now we have 2 stores for this purpose:

1. src/hooks/use-block-context.js
2. src/plugins/get-client-id-tree/store.js

I believe both of these are used solely for updating block context, so we should be able to combine these into just one.

[andeng1106]

@mxkae Remaining issue:

• Related to If Stackable blocks are inside synced patterns and duplicated, blocks has the same id which makes settings apply to both original and duplicated block #2822

Screen_Recording_2024-03-22_at_3.52.45_PM.mov

cc @bfintal