This repository has been archived by the owner on Feb 13, 2020. It is now read-only.
Implement Machine fix for host-only adapter #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -115,6 +115,7 @@ def _stop_docker_vm(): | |||
| """Stop the Dusty VM if it is not already stopped.""" | |||
| check_call_demoted(['docker-machine', 'stop', constants.VM_MACHINE_NAME], redirect_stderr=True) | |||
|
|
|||
| @memoized | |||
| def _get_vm_config(): | |||
| return check_output_demoted(['VBoxManage', 'showvminfo', '--machinereadable', constants.VM_MACHINE_NAME]).splitlines() | |||
There was a problem hiding this comment.
why is this worth memoizing? Is it really slow? seems like needless speedup with costs.
There was a problem hiding this comment.
I see, you reset it in ensure_docker_vm_is_started(). So should not change without caching being busted. Still curious about speedup. We call it 2X less right? Not like we are pinging this like crazy?
There was a problem hiding this comment.
Not hitting it super hard, but it does take about 150ms each time
thieman
force-pushed
the
tnt-host-only-fix
branch
from
5f97926
to
4f6a5ad
Compare
thieman
added a commit
that referenced
this pull request
Mar 2, 2016
Implement Machine fix for host-only adapter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@paetling This brings docker/machine#3112 into Dusty. We ported the Machine code that gets the VM IP into Dusty to get around Machine's slow startup times. Unfortunately, that means we need to keep the underlying code in sync when big bug fixes go out.
As part of this, attempted to memoize the
VBoxManage showvminfocall. Busting cache whenever we take the machine up/down to make it pick up VM config changes we sometimes make, e.g. changing the NIC. Will want to run this through its paces in RC, the memoize part might have broken stuff.