Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add EOS notes on Palworld and The Isle Evrima #522

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

podrivo
Copy link
Contributor

@podrivo podrivo commented Jan 29, 2024

This adds EOS Notes on Palworld and The Isle Evrima.
Closes this issue: #520

Also, would like to have more input on a better solution for detecting this protocol on tools/generate_games_list.js
It's currently like this:

if (
  game.options.protocol === 'epic' || 
  game.options.protocol === 'asa' || 
  game.options.protocol === 'palworld' || 
  game.options.protocol === 'theisleevrima'
) {
  notes.push('[EOS Protocol](#epic)')
}

@CosminPerRam CosminPerRam linked an issue Jan 29, 2024 that may be closed by this pull request
Copy link
Member

@CosminPerRam CosminPerRam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks bunch, that if is getting quite long, we'll have to see about that, but its fine for now.

@CosminPerRam CosminPerRam merged commit 453bafa into gamedig:master Jan 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Palworld player array empty
2 participants