Added c query requests for gtasao (open.mp) #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CosminPerRam
requested changes
Feb 22, 2024
protocols/gtasao.js
Outdated
| super() | ||
| this.isOmp = true | ||
| } | ||
| } |
There was a problem hiding this comment.
Please add a trailing newline here (:
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #388. User who opened the issue was right and has been backed up by various open.mp devs.
Dquery is not yet supported by omp, which breaks regulargtasamqueries on these servers, resulting in an emptyplayersarray. A workaround is usingCqueries instead, similarly to howvcmis handled, which returns a less detailed, but handy array of players along with their scores.This adds a separate protocol for the already existing
gtasaoquery type, which extends basesamp. This new protocol sends aCpacket instead ofDand will consequently return a populated array of players, as expected.Below are 2 queries for a server running open.mp with these changes added. More of a before and afer since both queries previously returned empty players arrays.
gtasam (D query - empty player list)
gtasao (C query - populated player list)