Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix for new importing style for cheerio #602

Closed
wants to merge 6 commits into from

Conversation

jammsen
Copy link
Contributor

@jammsen jammsen commented Aug 10, 2024

Currently you cant start apps, because node-gamedig uses cheerio, which just released a 1.0.0 release which omitted the old way of importing modules.

Source:
image

cheeriojs/cheerio#3986 and the fix and explainer to this - https://github.com/cheeriojs/cheerio/releases/tag/v1.0.0

@CosminPerRam
Copy link
Member

Hey, can you please do a MRE?
package-lock.json still specifies de release candidate version of the cheerio library and shouldn't be an issue.

@FingerlessGlov3s
Copy link

I've had to make this change manually on my lgsm as it was causing the healthcheck probes to fail.

NPM packages if wanted

root@d52ea70abad0:/app/lgsm# npm list
linuxgsm@ /app/lgsm
├── cheerio@1.0.0
├── gamedig@5.1.0
├── prettier-plugin-sh@0.13.1
└── prettier@3.3.3

@CosminPerRam
Copy link
Member

Hey, unfortunately I can't merge this PR, the fix works, but the problem is that the 1.0.0 version has a required minimum node version of 18, and node-gamedig v5 has 16.
I'll link here a PR that hardlocks the cheerio version to that latest RC.

thanks @FingerlessGlov3s

@CosminPerRam
Copy link
Member

Gamedig 5.1.1 and 4.3.2 are released with the fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants