-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several changes (see below for details) #114
Conversation
mireianievas
commented
Feb 9, 2018
- Fix enrico_tsmap so that it works (to be checked) with summed likelihood components (I changed it some time ago so even the front+back analysis was treated under the summed likelihood umbrella).
- Turn ebl_tau fit off by default
- make sure gtexpmap receives nenergies >=2 (useful for very fine energy binning)
- two extra way of computing the energy bins (sed points):
- width based on the photon statistics (so that flux errors are roughly equal)
- the standard fixed-logE-width (default)
- something in between (the result is appealing to my eyes)
- Fix labeling of index vs time in the LC plots when leaving index as a free parameter
- Add the 8yr point source catalog as a possibility (it is fetched during download_aux and it can be used by manually setting it in the conf file, extended sources need to be checked though).
…sing loglike object. The macro was broken when I set the use of summedlikelihood as the default type of analysis.
- code for tuning the spectral parameters in energy bins is now slighly more elegant (by defining a variable 'spectrum')
Try to use instead Scale (decorrelation energy)
…ant or mix=intermediate)
Hi |
Sounds good to me. The 8year catalog code is implemented as an 'if' automatically detecting that it is indeed that catalog. It is anyway not used by default, but it is fine with me anyway. I implemented it because I needed to do some checks in the analysis of one source :) |
Hi |
Catch RuntimeErrors when the calculation of UpperLimits fail (due to e.g. lack of photons in the field) Make it possible to use weekly spacecraft files (instead of the big, full-mission, file) Spacecraft file list sometimes is called as a normal input file, in some Sciencetools binaries with the @ Fixes on the second event cut, it introduces duplicates entries in header which make the unbinned analysis fail.
…r when running energybins. Now if the analysis tries to proccess an energy bin, it switches off the RA/DEC by setting the cuts to RA/DEC=0 and RAD=180. - Switch to SL7 cluster nodes in DESY cluster.
Hi |
Could be, and totally my fault. I have been trying to make some fixes in my fork, I should have tried to come closer to the main repository long time ago, I will try to merge your changes now :) |
Conflicts: enrico-init.sh enrico/RunGTlike.py enrico/appertureLC.py enrico/config/default.conf enrico/energybin.py enrico/fitmaker.py enrico/gtfunction.py enrico/lightcurve.py enrico/plotting.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not merge it yet ....
I merged the pull request; should be fine right? |
Yes.
I'm still doing some tests. With all the cleanup in the code and the fit
component management it looks like the XML for ebins now does not update
the spectral values (particularly the energy scale).
|