Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several changes (see below for details) #114

Merged
merged 25 commits into from
Aug 29, 2018

Conversation

mireianievas
Copy link
Contributor

  1. Fix enrico_tsmap so that it works (to be checked) with summed likelihood components (I changed it some time ago so even the front+back analysis was treated under the summed likelihood umbrella).
  2. Turn ebl_tau fit off by default
  3. make sure gtexpmap receives nenergies >=2 (useful for very fine energy binning)
  4. two extra way of computing the energy bins (sed points):
  • width based on the photon statistics (so that flux errors are roughly equal)
  • the standard fixed-logE-width (default)
  • something in between (the result is appealing to my eyes)
  1. Fix labeling of index vs time in the LC plots when leaving index as a free parameter
  2. Add the 8yr point source catalog as a possibility (it is fetched during download_aux and it can be used by manually setting it in the conf file, extended sources need to be checked though).

@davidsanchez
Copy link
Member

Hi
thanks for all. I'am also working on the code and I will make several changes. I'll reject your pull but I take your change and implment them manually
concernign the 8 years catalogue, I do not want to have it supported since the structure will likely change and one of the model used is not supported by the current ST version. Mabye this is worth have it as a script
thanks
david

@mireianievas
Copy link
Contributor Author

Sounds good to me.

The 8year catalog code is implemented as an 'if' automatically detecting that it is indeed that catalog. It is anyway not used by default, but it is fine with me anyway. I implemented it because I needed to do some checks in the analysis of one source :)

@davidsanchez
Copy link
Member

Hi
thanks for adding desy cluster. Could you open a pull request for this file alone.
thnks

Mireia Nievas added 3 commits July 5, 2018 11:20
Catch RuntimeErrors when the calculation of UpperLimits fail (due to e.g. lack of photons in the field)
Make it possible to use weekly spacecraft files (instead of the big, full-mission, file)
Spacecraft file list sometimes is called as a normal input file, in some Sciencetools binaries with the @
Fixes on the second event cut, it introduces duplicates entries in header which make the unbinned analysis fail.
…r when running energybins.

  Now if the analysis tries to proccess an energy bin, it switches off the RA/DEC by setting
  the cuts to RA/DEC=0 and RAD=180.
- Switch to SL7 cluster nodes in DESY cluster.
@davidsanchez
Copy link
Member

Hi
it seems that there is conflict with the curent version right?
cheeers
david

@mireianievas
Copy link
Contributor Author

Could be, and totally my fault. I have been trying to make some fixes in my fork, I should have tried to come closer to the main repository long time ago, I will try to merge your changes now :)

Conflicts:
	enrico-init.sh
	enrico/RunGTlike.py
	enrico/appertureLC.py
	enrico/config/default.conf
	enrico/energybin.py
	enrico/fitmaker.py
	enrico/gtfunction.py
	enrico/lightcurve.py
	enrico/plotting.py
Copy link
Contributor Author

@mireianievas mireianievas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge it yet ....

@davidsanchez davidsanchez merged commit 29cac33 into gammapy:master Aug 29, 2018
@davidsanchez
Copy link
Member

I merged the pull request; should be fine right?

@mireianievas
Copy link
Contributor Author

mireianievas commented Aug 29, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants