Remove region from PhaseBackgroundEstimator

gammapy · Oct 30, 2019 · 0111f69 · 0111f69
1 parent be2fcc6
commit 0111f69
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/gammapy/spectrum/phase.py b/gammapy/spectrum/phase.py
@@ -23,8 +23,7 @@ class PhaseBackgroundMaker:
         off-phase defined by the two edges of each interval (edges are excluded)
     """
 
-    def __init__(self, region, on_phase, off_phase):
-        self.region = region
+    def __init__(self, on_phase, off_phase):
         self.on_phase = self._check_intervals(on_phase)
         self.off_phase = self._check_intervals(off_phase)
 
@@ -35,7 +34,7 @@ def __str__(self):
         return s
 
     def _make_counts(self, dataset, observation, phases):
-        events = observation.events.select_region(self.region)
+        events = observation.events.select_region(dataset.counts.region)
 
         event_lists = []
         for interval in phases:

diff --git a/gammapy/spectrum/tests/test_phase.py b/gammapy/spectrum/tests/test_phase.py
@@ -29,7 +29,6 @@ def observations():
 def phase_bkg_maker(on_region):
     """Example background estimator for testing."""
     return PhaseBackgroundMaker(
-        region=on_region,
         on_phase=(0.5, 0.6),
         off_phase=(0.7, 1),
     )

diff --git a/tutorials/pulsar_analysis.ipynb b/tutorials/pulsar_analysis.ipynb
@@ -384,7 +384,7 @@
     "    e_reco=e_reco, e_true=e_true, region=on_region\n",
     ")\n",
     "phase_bkg_maker = PhaseBackgroundMaker(\n",
-    "    on_phase=on_phase_range, off_phase=off_phase_range, region=on_region\n",
+    "    on_phase=on_phase_range, off_phase=off_phase_range\n",
     ")\n",
     "safe_mask_maker = SafeMaskMaker(methods=[\"aeff-default\", \"edisp-bias\"], bias_percent=20)\n",
     "\n",