You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
# TODO: Improve by exposing a mode 'edge' for get_coord
I tried to do this in the past 10 min, but the code there is a bit complex.
So this is a reminder issue for myself to first implement mode="edge" for WcsGeom.get_coord with tests, and to adapt the solid_angle caller, and only then to finish up #1573 .
The text was updated successfully, but these errors were encountered:
In #1573 apparently @adonath tried to implement
mode="edge"forWcsGeom.get_coord, see his edits here: https://github.com/gammapy/gammapy/pull/1573/files#diff-3cf936d0601fe08b95aa7b11fb9cf614This doesn't work yet, it causes test fails in gammapy.maps:
https://ci.appveyor.com/project/cdeil/gammapy/build/1.0.3897/job/04tkynv5dibs2jbq#L2313
The missing
mode="edge"forWcsGeom.get_coordwas already noticed here:gammapy/gammapy/maps/wcs.py
Line 698 in a4dad70
I tried to do this in the past 10 min, but the code there is a bit complex.
So this is a reminder issue for myself to first implement
mode="edge"forWcsGeom.get_coordwith tests, and to adapt thesolid_anglecaller, and only then to finish up #1573 .The text was updated successfully, but these errors were encountered: