Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Fermi Galactic center dataset #201

Closed
cdeil opened this issue Sep 21, 2014 · 2 comments
Closed

Update Fermi Galactic center dataset #201

cdeil opened this issue Sep 21, 2014 · 2 comments
Labels
bug effort-medium package-novice
Milestone
0.8

Comments

@cdeil
Copy link
Contributor

cdeil commented Sep 21, 2014

As discussed in #183 and #191 the Galactic center PSF containment radius doesn't match the quoted IRF.

It would be best to reproduce all the files here by re-using the script for the Vela region dataset.

The only reason to keep the Galactic center dataset is that it's small enough to be bundled in the Gammapy repo and thus can be used for unit tests.
@cdeil cdeil added this to the 0.2 milestone Sep 21, 2014
@cdeil cdeil mentioned this issue Sep 21, 2014
Closed
@cdeil cdeil modified the milestones: 0.2, 0.3 Apr 8, 2015
@cdeil cdeil modified the milestones: 1.0, 0.3 May 30, 2015
@cdeil cdeil modified the milestones: 1.0, 0.8 Jul 26, 2018
@cdeil
Copy link
Contributor Author

cdeil commented Jul 26, 2018

This is one of the remaining users of SkyCube:
https://github.com/gammapy/gammapy/blob/master/gammapy/datasets/fermi.py

We have to decide what to do here and clean this up, so moving this to the v0.8 milestone.

@cdeil cdeil mentioned this issue Jul 30, 2018
Merged
@cdeil
Copy link
Contributor Author

cdeil commented Jul 30, 2018

Removed in #1593 .

@cdeil cdeil closed this as completed Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug effort-medium package-novice
Projects
None yet
Milestone
0.8
Development

No branches or pull requests
1 participant
@cdeil