Refactor model serialisation code #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move and simplify the serialization remaining code from datasets.io and modeling.models.io into the datasets and models classes.
Codecov Report
@@ Coverage Diff @@
## master #2822 +/- ##
==========================================
- Coverage 91.98% 91.97% -0.02%
==========================================
Files 147 145 -2
Lines 16559 16536 -23
==========================================
- Hits 15232 15209 -23
Misses 1327 1327
Continue to review full report at Codecov.
|
adonath
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move (and simplify) the remaining serialization code from datasets.io and modeling.models.io into the datasets and models classes.