Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up gammapy.stats #2842

Merged
merged 9 commits into from
Mar 29, 2020
Merged

Clean up gammapy.stats #2842

merged 9 commits into from
Mar 29, 2020

Conversation

registerrier
Copy link
Contributor

Description

This pull request is a clean-up of gammapy.stats. It removes poisson.py and normal.py.

To do so an excess_matching_significance method is added to the CountsStatistic base class.
The significance and significance_on_off calls in the code are replace with CashCountsStatistic.significance and WStatCountsStatistic.significance respectively.

The helene_ul function is removed as well as the significance_to_probability functions which are never used in the code base.

Dear reviewer

@registerrier registerrier self-assigned this Mar 27, 2020
@registerrier registerrier added this to the 0.17 milestone Mar 27, 2020
@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #2842 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2842      +/-   ##
==========================================
- Coverage   92.18%   92.18%   -0.01%     
==========================================
  Files         147      145       -2     
  Lines       16771    16588     -183     
==========================================
- Hits        15461    15292     -169     
+ Misses       1310     1296      -14     
Impacted Files Coverage Δ
gammapy/stats/__init__.py 100.00% <ø> (ø)
gammapy/datasets/spectrum.py 95.39% <100.00%> (ø)
gammapy/estimators/asmooth_map.py 92.70% <100.00%> (ø)
gammapy/estimators/sensitivity.py 100.00% <100.00%> (ø)
gammapy/stats/counts_statistic.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f4f2a0...28e1faa. Read the comment docs.

Copy link
Member

@adonath adonath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @registerrier, so far I have no comments, I'll go ahead an merge and polish in master if needed...

@adonath adonath merged commit 1292ac8 into gammapy:master Mar 29, 2020
@adonath adonath changed the title Cleaning gammapy.stats Clean up gammapy.stats Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants