-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up gammapy.stats #2842
Clean up gammapy.stats #2842
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2842 +/- ##
==========================================
- Coverage 92.18% 92.18% -0.01%
==========================================
Files 147 145 -2
Lines 16771 16588 -183
==========================================
- Hits 15461 15292 -169
+ Misses 1310 1296 -14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @registerrier, so far I have no comments, I'll go ahead an merge and polish in master if needed...
Description
This pull request is a clean-up of gammapy.stats. It removes poisson.py and normal.py.
To do so an
excess_matching_significance
method is added to theCountsStatistic
base class.The
significance
andsignificance_on_off
calls in the code are replace withCashCountsStatistic.significance
andWStatCountsStatistic.significance
respectively.The
helene_ul
function is removed as well as thesignificance_to_probability
functions which are never used in the code base.Dear reviewer