-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shorter tags for models #2938
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2938 +/- ##
==========================================
- Coverage 93.38% 93.34% -0.04%
==========================================
Files 147 147
Lines 16957 16991 +34
==========================================
+ Hits 15835 15860 +25
- Misses 1122 1131 +9
Continue to review full report at Codecov.
|
Thanks a lot @QRemy! As discussed in the meeting this morning, please adapt the YAML tags to the one proposed in PIG 21 here: https://github.com/gammapy/gammapy/blob/0ab86da3d9fca7046e67b40f23332442d1e715b9/docs/development/pigs/pig-21.rst#simplify-yaml-representation I'll continue with the review this afternoon... |
Redefine most of models tags with a list including shorter aliases to be used with model.create(tag) and in YAML serialization. By default the tag returned in model.to_dict() is the 0th tag which is also the class name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @QRemy, I have no further comments. We just should add some documentation on this soon...
Redefine most of models tags with a list including shorter aliases to be used with model.create(tag) and in YAML serialization. By default the tag returned in model.to_dict() is the 0th tag which is also the class name.