-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codespell infrastructure #3559
Codespell infrastructure #3559
Conversation
For future reference |
Finally note that codespell works in a peculiar way: it doesn't operate with a dictionary of valid words, instead it operates with a dictionary of typos. So it might not catch unusual/new typos. Do not hesitate to contribute your own typos. |
Codecov Report
@@ Coverage Diff @@
## master #3559 +/- ##
=======================================
Coverage 93.87% 93.87%
=======================================
Files 159 159
Lines 19216 19216
=======================================
Hits 18039 18039
Misses 1177 1177 Continue to review full report at Codecov.
|
Thanks a lot @DimitriPapadopoulos! One last nitpicky comment: can you use either dashes or underscores consistently in the filenames of the ignore and exclude files? Otherwise this PR is ready from from my side. |
Should be OK now. |
@DimitriPapadopoulos Now the commits adding the infrastructure are gone... |
Run codespell from the root directory of the project as `codespell`. Alternatively run `make codespell`, again from the root directory. In both case it will pick up adequate options from setup.cfg.
Ah, sorry about that. It's fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @DimitriPapadopoulos! No further comments from my side...
Description
Codespell infrastructure as suggested in #3548 (comment).
Dear reviewer
I have added a commit with a very small set of typos in infrastructure files, they shouldn't get in the way of future PRs. I can remove it if you don't want it, but it's not very intrusive and fixes the typos that got in the way while preparing these PRs.