Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyflakes for static code checks in CI #3756

Closed
maxnoe opened this issue Jan 27, 2022 · 0 comments · Fixed by #3760
Closed

Use pyflakes for static code checks in CI #3756

maxnoe opened this issue Jan 27, 2022 · 0 comments · Fixed by #3760
Labels

Comments

@maxnoe
Copy link
Member

maxnoe commented Jan 27, 2022

Is your feature request related to a problem? Please describe.

We made great experience in ctapipe and lstchain runnig pyflakes to catch simple static errors before running the unit test suite.

Describe the solution you'd like

Run pyflakes on gammapy as part of the CI

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context

Currently, pyflakes reports a large number of issues in gammapy:

❯ pyflakes gammapy | wc -l
294

However, most of them are related to star imports which make static checking per file for undefined objects impossible.

We should fix these issues to be able to use pyflakes as part of the CI.

@maxnoe maxnoe added the feature label Jan 27, 2022
Bultako added a commit that referenced this issue Feb 2, 2022
Fix issues reported by pyflakes and add pyflakes step to ci, fixes #3756
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant