Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to stack mask_fit in Dataset.stack #4015

Merged
merged 9 commits into from
Jul 22, 2022
Merged

Allow to stack mask_fit in Dataset.stack #4015

merged 9 commits into from
Jul 22, 2022

Conversation

QRemy
Copy link
Contributor

@QRemy QRemy commented Jun 30, 2022

Allow to stack mask_fit in Dataset.stack in the same way than mask_safe

@QRemy QRemy requested a review from registerrier June 30, 2022 10:11
@QRemy QRemy added the cleanup label Jun 30, 2022
@QRemy QRemy added this to the 1.0 milestone Jul 1, 2022
@QRemy
Copy link
Contributor Author

QRemy commented Jul 4, 2022

Remaining test failures seem unrelated as they appear in other PRs

adonath
adonath requested changes Jul 20, 2022
View reviewed changes
Copy link
Member

@adonath adonath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @QRemy, I have left one inline suggestion. I think we should copy the other mask...

gammapy/datasets/map.py Outdated Show resolved Hide resolved
@QRemy @adonath
Update gammapy/datasets/map.py
9595b35 
Co-authored-by: Axel Donath <adonath@users.noreply.github.com>
registerrier
registerrier approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@registerrier registerrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @QRemy

@registerrier
Copy link
Contributor

@adonath comment has been taken into account. Merging now.

@registerrier registerrier merged commit cea983c into gammapy:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adonath adonath adonath requested changes

@registerrier registerrier registerrier approved these changes

Assignees

@registerrier registerrier

Labels
cleanup
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QRemy @registerrier @adonath