Add sample_coord for RegionNDMap #4088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonath
reviewed
Sep 19, 2022
adonath
previously approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Thanks a lot @registerrier! Great to see that just moving the method up the hierarchy works. You could optionally simplify the test by removing the creation of the Table.
adonath
previously approved these changes
Sep 19, 2022
|
@registerrier Merging #4085 introduced a merge conflict, would you mind rebasing this PR here? Thanks! |
registerrier
force-pushed
the
region_sample
branch
from
cefb9aa
to
88d3cae
Compare
|
I just rebased. |
Signed-off-by: Terrier <rterrier@apc.in2p3.fr>
Signed-off-by: Terrier <rterrier@apc.in2p3.fr>
Signed-off-by: Terrier <rterrier@apc.in2p3.fr>
Signed-off-by: Terrier <rterrier@apc.in2p3.fr>
registerrier
force-pushed
the
region_sample
branch
from
88d3cae
to
c9b2428
Compare
Signed-off-by: Terrier <rterrier@apc.in2p3.fr>
Codecov Report
@@ Coverage Diff @@
## master #4088 +/- ##
==========================================
- Coverage 94.02% 93.99% -0.03%
==========================================
Files 162 162
Lines 21459 21430 -29
==========================================
- Hits 20176 20144 -32
- Misses 1283 1286 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
adonath
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request moves the
sample_coordmethod to the baseMapto allow sampling ofRegionNDMap.For now the implementation fails with
HpxNDMap, aNotImplmentedErroris therefore raised inHpxNDMap.sample_coord.This should help #4087 and #4070 .
Dear reviewer