You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Currently, SkyModel.evaluate_geom(geom) does not support axes that are not energy_true. Calling it on a Geom object with additional axes will return an array with incorrect shape.
Describe the solution you'd like SkyModel.evaluate_geom(geom) should return an array of the correct size copying the contents for the additional axes.
Special caution should be taken for time axis. For three reasons:
currently the time is evaluated via the gti argument. This is an incorrect approach as gti is relevant on the MapEvaluator, not on the model. Note that a TimeMapAxis.from_gti() factory method exists.
evaluate_geom actually integrates over time. Is this still necessary? Does it make sense?
A MapAxis can represent a time-like quantity but does not contain a reference time. This has to be verified.
Another question, is how to handle energy axis (instead of energy_true).
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
Currently,
SkyModel.evaluate_geom(geom)
does not support axes that are notenergy_true
. Calling it on aGeom
object with additional axes will return an array with incorrect shape.Describe the solution you'd like
SkyModel.evaluate_geom(geom)
should return an array of the correct size copying the contents for the additional axes.Special caution should be taken for
time
axis. For three reasons:gti
argument. This is an incorrect approach asgti
is relevant on theMapEvaluator
, not on the model. Note that aTimeMapAxis.from_gti()
factory method exists.evaluate_geom
actually integrates over time. Is this still necessary? Does it make sense?MapAxis
can represent a time-like quantity but does not contain a reference time. This has to be verified.Another question, is how to handle
energy
axis (instead ofenergy_true
).The text was updated successfully, but these errors were encountered: