-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt SkyModel to evaluate on TimeMapAxis #4828
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4828 +/- ##
==========================================
+ Coverage 75.80% 75.83% +0.03%
==========================================
Files 227 227
Lines 33315 33401 +86
==========================================
+ Hits 25255 25331 +76
- Misses 8060 8070 +10 ☔ View full report in Codecov by Sentry. |
I have adapted This has the loop over axis bins, which is not nice. Any better suggestion will be much appreciated. The nice thing is this can allow Maybe we can merge this now, and I can adapt the |
After rebasing, I adapt |
Signed-off-by: Atreyee Sinha <asinha@ucm.es>
Signed-off-by: Atreyee Sinha <asinha@ucm.es>
Signed-off-by: Atreyee Sinha <asinha@ucm.es>
Signed-off-by: Atreyee Sinha <asinha@ucm.es>
Signed-off-by: Atreyee Sinha <asinha@ucm.es>
Signed-off-by: Atreyee Sinha <asinha@ucm.es>
Signed-off-by: Atreyee Sinha <asinha@ucm.es>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AtreyeeS, looks good, I just pushed a commit to reduce code duplication and left one question :
Signed-off-by: Quentin Remy <quentin.remy@mpi-hd.mpg.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AtreyeeS
Addresses remaining part of #4480 - adapt SkyModel.evaluate_geom() and SkyModel.integrate_geom() to work with a TimeMapAxis