Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old flux point classes #814

Merged
merged 7 commits into from Dec 12, 2016
Merged

Remove old flux point classes #814

merged 7 commits into from Dec 12, 2016

Conversation

adonath
Copy link
Member

@adonath adonath commented Dec 10, 2016

This PR removes the old DifferentialFluxPoints and IntegralFluxPoints classes, from the gammapy.spectrum module, tests and docs and all uses of it.

@joleroi @cdeil There's a SpectrumFit.compute_fluxpoints() method which seems to never have worked. I added raise NotImplementedError let me know, if I should remove it completely

@adonath adonath added this to the 0.6 milestone Dec 10, 2016
@adonath adonath self-assigned this Dec 10, 2016
@cdeil
Copy link
Contributor

cdeil commented Dec 10, 2016

🎉 , thanks for the cleanup!

I don't remember if I was involved with adding SpectrumFit.compute_fluxpoints or if it's something @joleroi did:
https://github.com/gammapy/gammapy/blame/080a1498d6e390b6d4a7feabafb6f2a71b28f4aa/gammapy/spectrum/fit.py#L225

I'll add @joleroi as reviewer now.
But @adonath - if you want to merge this now, no worries, we can always bring stuff back from version history.

@cdeil cdeil requested a review from joleroi December 10, 2016 15:02
@adonath
Copy link
Member Author

adonath commented Dec 10, 2016

@joleroi Could you please update this notebook to use FluxPoints instead of DifferentialFluxPoints? Once the change is done Travis-CI should pass...Thanks!

joleroi
joleroi approved these changes Dec 12, 2016
View reviewed changes
Copy link
Contributor

@joleroi joleroi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adonath and I fixed the remaining issues, all looks fine now. Let's see if tests pass ...

@adonath adonath force-pushed the remove_old_flux_point_classes branch from 4512e2c to 76037de Compare December 12, 2016 14:53
@adonath adonath force-pushed the remove_old_flux_point_classes branch from 76037de to 14a396d Compare December 12, 2016 15:10
@adonath adonath merged commit 775705b into gammapy:master Dec 12, 2016
@adonath
Copy link
Member Author

adonath commented Dec 12, 2016

Thanks @joleroi!

@joleroi
Copy link
Contributor

joleroi commented Dec 12, 2016

+65 -265
itwasagoodday

@adonath adonath deleted the remove_old_flux_point_classes branch November 20, 2018 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joleroi joleroi joleroi approved these changes

Assignees

@adonath adonath

Labels
cleanup
Projects
None yet
Milestone
0.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adonath @cdeil @joleroi