New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spiralarm=False case in make_base_catalog_galactic #1021

Merged
merged 1 commit into from May 9, 2017

Conversation

Projects
None yet
2 participants
@rlopezcoto
Contributor

rlopezcoto commented May 9, 2017

This PR fixes the issue reported in #1020 .

added an if statement to check if the “spiralarms” option is True. If
it is not, this column is unnecessary in the table

Bug fix spiralarm=False
added an if statement to check if the “spiralarms” option is True. If
it is not, this column is unnecessary in the table

@cdeil cdeil self-assigned this May 9, 2017

@cdeil cdeil added the bug label May 9, 2017

@cdeil cdeil added this to the 0.7 milestone May 9, 2017

@cdeil cdeil changed the title from Bug fix spiralarm=False to Fix spiralarm=False case in make_base_catalog_galactic May 9, 2017

@cdeil cdeil merged commit 42e197c into gammapy:master May 9, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil May 9, 2017

Member

Thanks!

Welcome to the club: d9b7388

Member

cdeil commented May 9, 2017

Thanks!

Welcome to the club: d9b7388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment