Add combined 3D model and simple npred function #1040
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a continuation of #1029 where @robertazanin and I started to implement an example for 3D model evaluation and npred computation (and eventually simulating / fitting 3D).
What I have so far is moved the following things from the example script into Gammapy:
gammapy.cube.CombinedModel3D
and some testsgammapy.cube.compute_npred_cube_simple
What I still plan to do in this pull request:
CombinedModel3D
CombinedModel3D
The next steps are then this, which I'll leave to future PRs:
_sherpa.py
If anyone is interested in helping to implement something in this direction, please let me know.
@adonath - If you have time to review, please do. (I'll probably merge soon and start with follow-up PRs, but comments are welcome any time and then taken into account there).