Add easy access to parameter errors #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdeil
approved these changes
Jun 20, 2017
| raise ValueError('Covariance matrix not set.') | ||
|
|
||
| for i, parameter in enumerate(self.parameters): | ||
| if parameter.name == parname: |
There was a problem hiding this comment.
This lookup of parameter by name could / should be a separate method that takes the name and returns the int index, no? If you don't want to implement that here, OK to merge anyways of course.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment there's no simple possibility to access the errors of model parameters, except via fiddling with the covariance matrix oder the hidden
_ufloatsparameter.This PR add a function
errortoParameterListto over come this, of course it's just a temporary solution until we have a proper covariance matrix class.cc @Ozi1Kenobi