Remove catalog and data browser Flask web apps #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the catalog and data browser Flask web apps.
Those were things I started to add two or three years ago, because I wanted the functionality (to browse catalog data and FITS data from HESS) and wanted to learn how Python-powered web pages with Flask work. Looking back at this now, it's pretty clear that Flask web apps is not the way to go in Gammapy. If someone wants to build web apps as GUIs to do analysis with Gammapy, they can in their projects / repos, but given that Gammapy developers aren't familar / excited by HTML / Javascript / Jinja / Flask we shouldn't put and maintain it in the Gammapy package.
I do think we should allow widgets or web GUIs in Gammapy as long as they are almost exclusively Python code and thus not very hard to maintain and potentially useful to a good fraction of users. Concretely Bokeh is something to look at, and in the coming weeks JupyterLab will be released, which is the evolution of the Jupyter notebook and Jupyter widgets that we already use and that many devs and users are familiar with and like (see e.g. http://blog.jupyter.org/2016/07/14/jupyter-lab-alpha/ or the upcoming http://go.continuum.io/registration-jupyterlab-next-generation-ds-ide/ and https://conferences.oreilly.com/jupyter/jup-ny ).
So if anyone is interested to implement Jupyter widgets or other GUI functionality (or just example docs) how to browse gamma-ray data or catalog data, please open a new issue if you have any questions or a pull request if you have implemented something.
For catalog data there's also http://gamma-sky.net/#/cat by now for cases where you just want to look up some info on a given source.