New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up catalog image code #1238

Merged
merged 2 commits into from Dec 17, 2017

Conversation

Projects
None yet
2 participants
@adonath
Copy link
Member

adonath commented Dec 15, 2017

This PR removes a lot of old, broken and untested code from gammapy/image/catalog.py. All of the functionality was replaced by the CatalogImageEstimator class. I added a minimal docs example how to compute a flux SkyCube from a given catalog.

@adonath adonath added this to the 0.7 milestone Dec 15, 2017

@adonath adonath self-assigned this Dec 15, 2017

@cdeil

cdeil approved these changes Dec 17, 2017

Copy link
Member

cdeil left a comment

@adonath - Thanks for removing this old code!

I know that you're aware, but just for reference for others that look at the tracker: the long-term solution is still to be written, using gammapy.maps and directly allowing filling 3D maps, and to go via model classes, i.e. convert the catalog to list of models or compound additive model that contains a list first, and then use that in model evaluation.

@cdeil cdeil merged commit c876bc5 into gammapy:master Dec 17, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@adonath adonath deleted the adonath:clean_up_catalog_image_code branch Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment