Clean up catalog image code #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdeil
approved these changes
Dec 17, 2017
There was a problem hiding this comment.
@adonath - Thanks for removing this old code!
I know that you're aware, but just for reference for others that look at the tracker: the long-term solution is still to be written, using gammapy.maps and directly allowing filling 3D maps, and to go via model classes, i.e. convert the catalog to list of models or compound additive model that contains a list first, and then use that in model evaluation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a lot of old, broken and untested code from
gammapy/image/catalog.py. All of the functionality was replaced by theCatalogImageEstimatorclass. I added a minimal docs example how to compute a fluxSkyCubefrom a given catalog.