New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PhaseCurve class for periodic systems #1300
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
287aadf
Adding PhaseCurve class for periodic system
labsaha 061dd8c
Updating PhaseCurve class
labsaha dece764
Updating the class
labsaha e0946d3
Improve PhaseCurve in gammapy.time.models
cdeil fff5ca5
Change PhaseCurve evaluate to make it a bit more modular
cdeil File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,113 @@ | ||
# Licensed under a 3-clause BSD style license - see LICENSE.rst | ||
from __future__ import absolute_import, division, print_function, unicode_literals | ||
import numpy as np | ||
from ..utils.modeling import Parameter, ParameterList | ||
|
||
__all__ = [ | ||
'PhaseCurve', | ||
] | ||
|
||
|
||
class PhaseCurve(object): | ||
"""Temporal phase curve model. | ||
|
||
Phase for a given time is computed as | ||
|
||
.. math:: | ||
|
||
\phi(t) = \phi0 + f0(t−t0) + (1/2)f1(t−t0)^2 + (1/6)f2(t−t0)^3 | ||
|
||
Strictly periodic sources such as gamma-ray binaries have ``f1=0`` and ``f2=0``. | ||
Sources like some pulsars where the period spins up or down have ``f1!=0`` | ||
and / or ``f2 !=0``. | ||
|
||
The "phase curve", i.e. multiplicative flux factor for a given phase is given | ||
by a `~astropy.table.Table` of nodes ``(phase, norm)``, using linear interpolation | ||
and circular behaviour, where ``norm(phase=0) == norm(phase=1)``. | ||
|
||
Parameters | ||
---------- | ||
table : `~astropy.table.Table` | ||
A table of 'PHASE' vs 'NORM' should be given | ||
time_0 : float | ||
The MJD value where phase is considered as 0. | ||
phase_0 : float | ||
Phase at the reference MJD | ||
f0, f2, f2 : float | ||
Derivatives of the function phi with time of order 1, 2, 3 | ||
|
||
Examples | ||
-------- | ||
Create an example phase curve object:: | ||
|
||
from astropy.table import Table | ||
from gammapy.utils.scripts import make_path | ||
from gammapy.time.models import PhaseCurve | ||
filename = make_path('$GAMMAPY_EXTRA/test_datasets/phasecurve_LSI_DC.fits') | ||
table = Table.read(str(filename)) | ||
phase_curve = PhaseCurve(table, time_0=43366.275, phase_0=0.0, f0=0.5, f1=0.0, f2=0.0) | ||
|
||
Use it to compute a phase and evaluate the phase curve model for a given time: | ||
|
||
>>> phase_curve.phase(time=46300.0) | ||
0.8624999999992724 | ||
>>> phase_curve.evaluate_at_phase(0.8624999999992724) | ||
>>> phase_curve.evaluate_at_time(46300.0) | ||
0.05 | ||
""" | ||
|
||
def __init__(self, table, time_0, phase_0, f0, f1, f2): | ||
self.table = table | ||
self.parameters = ParameterList([ | ||
Parameter('time_0', time_0), | ||
Parameter('phase_0', phase_0), | ||
Parameter('f0', f0), | ||
Parameter('f1', f1), | ||
Parameter('f2', f2)] | ||
) | ||
|
||
def phase(self, time): | ||
"""Evaluate phase for a given time. | ||
|
||
Parameters | ||
---------- | ||
time : array_like | ||
|
||
Returns | ||
------- | ||
phase : array_like | ||
""" | ||
pars = self.parameters | ||
time_0 = pars['time_0'].value | ||
phase_0 = pars['phase_0'].value | ||
f0 = pars['f0'].value | ||
f1 = pars['f1'].value | ||
f2 = pars['f2'].value | ||
|
||
t = time - time_0 | ||
phase = self._evaluate_phase(t, phase_0, f0, f1, f2) | ||
return np.remainder(phase, 1) | ||
|
||
@staticmethod | ||
def _evaluate_phase(t, phase_0, f0, f1, f2): | ||
return phase_0 + t * (f0 + t * (f1 / 2 + f2 / 6 * t)) | ||
|
||
def evaluate_norm_at_time(self, time): | ||
"""Evaluate for a given time. | ||
|
||
Parameters | ||
---------- | ||
time : array_like | ||
Time since the ``reference`` time. | ||
|
||
Returns | ||
------- | ||
norm : array_like | ||
""" | ||
phase = self.phase(time) | ||
return self.evaluate_norm_at_phase(phase) | ||
|
||
def evaluate_norm_at_phase(self, phase): | ||
xp = self.table['PHASE'] | ||
fp = self.table['NORM'] | ||
return np.interp(x=phase, xp=xp, fp=fp, period=1) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
# Licensed under a 3-clause BSD style license - see LICENSE.rst | ||
from astropy.table import Table | ||
import pytest | ||
from numpy.testing import assert_allclose | ||
from ...utils.scripts import make_path | ||
from ...utils.testing import requires_data | ||
from ..models import PhaseCurve | ||
|
||
|
||
@pytest.fixture(scope='session') | ||
def phase_curve(): | ||
filename = make_path('$GAMMAPY_EXTRA/test_datasets/phasecurve_LSI_DC.fits') | ||
table = Table.read(str(filename)) | ||
return PhaseCurve(table, time_0=43366.275, phase_0=0.0, f0=0.5, f1=0.0, f2=0.0) | ||
|
||
|
||
@requires_data('gammapy-extra') | ||
def test_phasecurve_phase(phase_curve): | ||
time = 46300.0 | ||
phase = phase_curve.phase(time) | ||
assert_allclose(phase, 0.8624999999992724) | ||
|
||
|
||
@requires_data('gammapy-extra') | ||
def test_phasecurve_evaluate(phase_curve): | ||
time = 46300.0 | ||
value = phase_curve.evaluate_norm_at_time(time) | ||
assert_allclose(value, 0.05) | ||
|
||
phase = phase_curve.phase(time) | ||
value = phase_curve.evaluate_norm_at_phase(phase) | ||
assert_allclose(value, 0.05) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the very top of each file in Gammapy we have the license line. Please add it.